This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Add service image build example #723
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #723 +/- ##
==========================================
- Coverage 72.45% 70.99% -1.46%
==========================================
Files 59 59
Lines 3438 3031 -407
==========================================
- Hits 2491 2152 -339
+ Misses 612 588 -24
+ Partials 335 291 -44
Continue to review full report at Codecov.
|
Signed-off-by: Christopher Crone <[email protected]>
chris-crone
force-pushed
the
service-build-demo
branch
from
1fcfa27
to
6bc0a3f
Compare
silvin-lubecki
approved these changes
Oct 30, 2019
| description: | ||
| # List of application maintainers with name and email for each | ||
| maintainers: | ||
| - name: chris |
There was a problem hiding this comment.
Beware, you'll have to maintain this app! 🧌
|
I still need to add a readme for this so will leave it in draft until that's done. |
|
https://github.com/docker/app/tree/master/examples/voting-app is already such a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added an example of a Docker App that has service images that can be built.
- Description for the changelog
N/A